Worklet: Straighten layering of worklet script loading

third_party/WebKit/Source/core/workers/Worklet.cpp

Index: third_party/WebKit/Source/core/workers/Worklet.cpp
diff --git a/third_party/WebKit/Source/core/workers/Worklet.cpp b/third_party/WebKit/Source/core/workers/Worklet.cpp
index 6dbdc7fbd29b322395ddae5c57bd646904c971e9..22d45a3db36cc5a06636a0a65b91e434d1b6cd2c 100644
--- a/third_party/WebKit/Source/core/workers/Worklet.cpp
+++ b/third_party/WebKit/Source/core/workers/Worklet.cpp
@@ -4,29 +4,23 @@
 
 #include "core/workers/Worklet.h"
 
-#include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptSourceCode.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/frame/LocalFrame.h"
-#include "core/loader/DocumentLoader.h"
-#include "core/loader/FrameFetchContext.h"
+#include "core/loader/resource/ScriptResource.h"
 #include "core/workers/WorkletGlobalScopeProxy.h"
-#include "core/workers/WorkletScriptLoader.h"
-#include "platform/loader/fetch/FetchInitiatorTypeNames.h"
 
 namespace blink {
 
 Worklet::Worklet(LocalFrame* frame)
-    : ContextLifecycleObserver(frame->document()),
-      m_fetcher(frame->loader().documentLoader()->fetcher()) {}
+    : ContextLifecycleObserver(frame->document()), m_frame(frame) {}
 
 ScriptPromise Worklet::import(ScriptState* scriptState, const String& url) {
-  if (!isInitialized()) {
+  if (!isInitialized())
     initialize();
-  }
 
   KURL scriptURL = getExecutionContext()->completeURL(url);
   if (!scriptURL.isValid()) {
@@ -35,42 +29,51 @@ ScriptPromise Worklet::import(ScriptState* scriptState, const String& url) {
         DOMException::create(SyntaxError, "'" + url + "' is not a valid URL."));
   }
 
-  ResourceRequest resourceRequest(scriptURL);
-  resourceRequest.setRequestContext(WebURLRequest::RequestContextScript);
-  FetchRequest request(resourceRequest, FetchInitiatorTypeNames::internal);
-  ScriptResource* resource = ScriptResource::fetch(request, fetcher());
-
   ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
   ScriptPromise promise = resolver->promise();
-  if (resource) {
-    WorkletScriptLoader* workletLoader =
-        WorkletScriptLoader::create(resolver, this, resource);
-    m_scriptLoaders.add(workletLoader);
-  } else {
+
+  WorkletScriptLoader* scriptLoader =
+      WorkletScriptLoader::create(m_frame, this);
+  m_loaderAndResolvers.set(scriptLoader, resolver);
+  if (!scriptLoader->fetchScript(scriptURL)) {
+    m_loaderAndResolvers.remove(scriptLoader);
     resolver->reject(DOMException::create(NetworkError));
   }
   return promise;
 }
 
+void Worklet::notifyCanceled(WorkletScriptLoader* scriptLoader) {
+  ScriptPromiseResolver* resolver = m_loaderAndResolvers.get(scriptLoader);
+  m_loaderAndResolvers.remove(scriptLoader);
+  resolver->reject(DOMException::create(NetworkError));
+}
+
 void Worklet::notifyFinished(WorkletScriptLoader* scriptLoader) {
+  ScriptPromiseResolver* resolver = m_loaderAndResolvers.get(scriptLoader);
+  if (scriptLoader->resource()->errorOccurred()) {
+    m_loaderAndResolvers.remove(scriptLoader);
+    resolver->reject(DOMException::create(NetworkError));
+    return;
+  }
+  DCHECK(scriptLoader->resource()->isLoaded());
+
   workletGlobalScopeProxy()->evaluateScript(
       ScriptSourceCode(scriptLoader->resource()));
-  m_scriptLoaders.remove(scriptLoader);
+  m_loaderAndResolvers.remove(scriptLoader);
+  resolver->resolve();
 }
 
 void Worklet::contextDestroyed(ExecutionContext*) {
-  if (isInitialized()) {
+  if (isInitialized())
     workletGlobalScopeProxy()->terminateWorkletGlobalScope();
-  }
-
-  for (const auto& scriptLoader : m_scriptLoaders) {
+  for (const auto& scriptLoader : m_loaderAndResolvers.keys())
     scriptLoader->cancel();
-  }
+  m_frame = nullptr;
 }
 
 DEFINE_TRACE(Worklet) {
-  visitor->trace(m_fetcher);
-  visitor->trace(m_scriptLoaders);
+  visitor->trace(m_frame);
+  visitor->trace(m_loaderAndResolvers);
   ContextLifecycleObserver::trace(visitor);
 }