PlzNavigate: set the error code in NavigationHandle on abort

extensions/browser/extension_navigation_throttle.cc

Index: extensions/browser/extension_navigation_throttle.cc
diff --git a/extensions/browser/extension_navigation_throttle.cc b/extensions/browser/extension_navigation_throttle.cc
index 68c0a92e340da9750e1fcff31bd267476f9f0e00..0c06bd83cffa8d41a921eba9972088fcdd0a4561 100644
--- a/extensions/browser/extension_navigation_throttle.cc
+++ b/extensions/browser/extension_navigation_throttle.cc
@@ -90,7 +90,7 @@ ExtensionNavigationThrottle::WillStartRequest() {
             is_guest, extension, owner_extension, partition_id, resource_path,
             navigation_handle()->GetPageTransition(), &allowed);
         if (!allowed)
-          return content::NavigationThrottle::CANCEL;
+          return content::NavigationThrottle::BLOCK_REQUEST;

[clamy, 2017/01/26 15:33:45]

Some tests expect this particular return code when this is triggered. I'm not
sure how they passed previously.

[Devlin, 2017/01/26 15:50:17]

Which tests?  I wonder if the return on line 64 should also be returning
BLOCK_REQUEST instead of cancel?

[clamy, 2017/01/26 15:58:06]

The issue was with
WebViewTests/WebViewTest.Shim_TestLoadAbortChromeExtensionURLWrongPartition/0.

[nasko, 2017/01/26 17:20:18]

Let's ensure that we pick the right error code we believe this code should be
returning. Tests can be fixed too. There is non-trivial difference between
cancelling and blocking, which one is the semantically correct here?

[clamy, 2017/01/27 17:21:51]

I've modified the other return, still letting the tests run to see if everything
is ok with it.

       }
     }