PlzNavigate: set the error code in NavigationHandle on abort

extensions/browser/extension_navigation_throttle.cc

Index: extensions/browser/extension_navigation_throttle.cc
diff --git a/extensions/browser/extension_navigation_throttle.cc b/extensions/browser/extension_navigation_throttle.cc
index 68c0a92e340da9750e1fcff31bd267476f9f0e00..0c06bd83cffa8d41a921eba9972088fcdd0a4561 100644
--- a/extensions/browser/extension_navigation_throttle.cc
+++ b/extensions/browser/extension_navigation_throttle.cc
@@ -90,7 +90,7 @@ ExtensionNavigationThrottle::WillStartRequest() {
             is_guest, extension, owner_extension, partition_id, resource_path,
             navigation_handle()->GetPageTransition(), &allowed);
         if (!allowed)
-          return content::NavigationThrottle::CANCEL;
+          return content::NavigationThrottle::BLOCK_REQUEST;

[clamy, 2017/02/07 11:58:28]

I went back to modifying just this return. After further research, this seems to
be the right result to return. As explained in the comment above, this
particular code path corresponds to the checks performed in
extensions::url_request_util::AllowCrossRendererResourceLoad when PlzNavigate is
disabled. Those are called by ExtensionProtocolHandler::MaybeCreateJob which
will cancel the request with an error code of net::ERR_BLOCKED_BY_CLIENT when
the checks fail
(https://cs.chromium.org/chromium/src/extensions/browser/extension_protocols.c...).
So returning content::NavigationThrottle::BLOCK_REQUEST matches what the code is
currently doing.

[jam1, 2017/02/08 16:03:40]

FWIW, when I originally ported this I first tried block_request to match the
other code, but because of the behavior this cl is fixing, I had to change it to
cancel to pass.

       }
     }