third_party/WebKit/Source/platform/testing/WebURLLoaderMockFactoryImpl.cpp - Issue 2657793002: Make WebURLLoaderMockFactoryImpl::createURLLoader accept nullptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/testing/WebURLLoaderMockFactoryImpl.cpp

Issue 2657793002: Make WebURLLoaderMockFactoryImpl::createURLLoader accept nullptr (Closed)

Patch Set: base change Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/testing/WebURLLoaderMock.cpp ('K') | « third_party/WebKit/Source/platform/testing/WebURLLoaderMock.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/testing/WebURLLoaderMockFactoryImpl.cpp

diff --git a/third_party/WebKit/Source/platform/testing/WebURLLoaderMockFactoryImpl.cpp b/third_party/WebKit/Source/platform/testing/WebURLLoaderMockFactoryImpl.cpp

index 62713abb1b816570dd9c7ad7b5e6f55f1928dbbc..09cf09cf22ea0e8e32aa34edfeb2eaa8a69b9663 100644

--- a/third_party/WebKit/Source/platform/testing/WebURLLoaderMockFactoryImpl.cpp

+++ b/third_party/WebKit/Source/platform/testing/WebURLLoaderMockFactoryImpl.cpp

@@ -32,7 +32,6 @@ WebURLLoaderMockFactoryImpl::~WebURLLoaderMockFactoryImpl() {}

WebURLLoader* WebURLLoaderMockFactoryImpl::createURLLoader(

WebURLLoader* defaultLoader) {

- DCHECK(defaultLoader);

return new WebURLLoaderMock(this, defaultLoader);

}

« third_party/WebKit/Source/platform/testing/WebURLLoaderMock.cpp ('K') | « third_party/WebKit/Source/platform/testing/WebURLLoaderMock.cpp ('k') | no next file » | no next file with comments »