Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1749)

Unified Diff: tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp

Issue 2657773003: Blacklisting renaming of |size()| and |length()| methods. (Closed)
Patch Set: Let's also blacklist |length| per https://crbug.com/672902#c9 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
diff --git a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
index eced8e2d4ff3c77b31cae9180377157432352bf9..9f009511d65a61714399159976eaf5d7fbcf2e7a 100644
--- a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
+++ b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
@@ -439,7 +439,7 @@ bool IsBlacklistedInstanceMethodName(llvm::StringRef name) {
// https://crbug.com/672902: Should not rewrite names that mimick methods
// from std library.
- "back", "empty", "erase", "front", "insert",
+ "back", "empty", "erase", "front", "insert", "length", "size",
};
for (const auto& b : kBlacklistedNames) {
if (name == b)
@@ -662,7 +662,6 @@ bool ShouldPrefixFunctionName(const std::string& old_method_name) {
"layoutBlock",
"layoutObject",
"layoutSize",
- "length",
"lineCap",
"lineEndings",
"lineJoin",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698