third_party/libxml/src/parser.c - Issue 2657773002: Don't read before the start of heap buffers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libxml/src/parser.c

Issue 2657773002: Don't read before the start of heap buffers. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libxml/src/parser.c

diff --git a/third_party/libxml/src/parser.c b/third_party/libxml/src/parser.c

index 33786f08354ddcb1c4bcdaeb9b57d313cfaeff57..745c3da1c72e11a896c6da1269a1cd7172c71242 100644

--- a/third_party/libxml/src/parser.c

+++ b/third_party/libxml/src/parser.c

@@ -3426,7 +3426,7 @@ xmlParseNameComplex(xmlParserCtxtPtr ctxt) {

xmlFatalErr(ctxt, XML_ERR_NAME_TOO_LONG, "Name");

return(NULL);

}

- if ((*ctxt->input->cur == '\n') && (ctxt->input->cur[-1] == '\r')) {

+ if (ctxt->input->cur > ctxt->input->base && (*ctxt->input->cur == '\n') && (ctxt->input->cur[-1] == '\r')) {

if (ctxt->input->base > ctxt->input->cur - (len + 1)) {

return(NULL);

}

« no previous file with comments | « third_party/libxml/README.chromium ('k') | no next file » | no next file with comments »