Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 265773004: Rename expectations for Valgrind bot: ATI5770->GTX550Ti (Closed)

Created:
6 years, 7 months ago by borenet
Modified:
6 years, 7 months ago
Reviewers:
caryclark
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Rename expectations for Valgrind bot: ATI5770->GTX550Ti This will likely cause GM failures, since the GPU has changed. BUG=skia:2506 Committed: http://code.google.com/p/skia/source/detail?r=14493

Patch Set 1 #

Messages

Total messages: 8 (0 generated)
borenet
6 years, 7 months ago (2014-05-01 12:11:39 UTC) #1
caryclark
lgtm
6 years, 7 months ago (2014-05-01 12:26:15 UTC) #2
borenet
The CQ bit was checked by borenet@google.com
6 years, 7 months ago (2014-05-01 12:26:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/265773004/1
6 years, 7 months ago (2014-05-01 12:26:44 UTC) #4
commit-bot: I haz the power
Change committed as 14493
6 years, 7 months ago (2014-05-01 12:32:47 UTC) #5
bsalomon
On 2014/05/01 12:32:47, I haz the power (commit-bot) wrote: > Change committed as 14493 Can ...
6 years, 7 months ago (2014-05-01 13:19:51 UTC) #6
borenet
On 2014/05/01 13:19:51, bsalomon wrote: > On 2014/05/01 12:32:47, I haz the power (commit-bot) wrote: ...
6 years, 7 months ago (2014-05-01 13:20:47 UTC) #7
bsalomon
6 years, 7 months ago (2014-05-01 13:22:59 UTC) #8
Message was sent while issue was closed.
On 2014/05/01 13:20:47, borenet wrote:
> On 2014/05/01 13:19:51, bsalomon wrote:
> > On 2014/05/01 12:32:47, I haz the power (commit-bot) wrote:
> > > Change committed as 14493
> > 
> > Can we just delete these? We don't need separate expectations for the
Valgrind
> > bot AFAIK.
> 
> Unfortunately no, skimage actually fails without any expectations.  The GM
> expectations are just empty.

oh ok

Powered by Google App Engine
This is Rietveld 408576698