[Blink, Media] Added controlsList to HTMLMediaElement

third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index b20a17edb06b0a4bee5031030d34d2891a6fd04a..66b353c02b4cedb24c56289d912060c3b43168db 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -464,7 +464,8 @@ HTMLMediaElement::HTMLMediaElement(const QualifiedName& tagName,
       m_autoplayUmaHelper(AutoplayUmaHelper::create(this)),
       m_remotePlaybackClient(nullptr),
       m_autoplayVisibilityObserver(nullptr),
-      m_mediaControls(nullptr) {
+      m_mediaControls(nullptr),
+      m_controlsList(HTMLMediaElementControlsList::create(this)) {
   BLINK_MEDIA_LOG << "HTMLMediaElement(" << (void*)this << ")";
 
   m_lockedPendingUserGesture = computeLockedPendingUserGesture(document);
@@ -597,6 +598,8 @@ void HTMLMediaElement::parseAttribute(
   } else if (name == controlsAttr) {
     UseCounter::count(document(),
                       UseCounter::HTMLMediaElementControlsAttribute);
+    if (params.oldValue != params.newValue)
+      m_controlsList->setValue(params.newValue);
     updateControlsVisibility();
   } else if (name == preloadAttr) {
     setPlayerPreload();
@@ -2437,6 +2440,18 @@ bool HTMLMediaElement::shouldShowControls(
   return false;
 }
 
+DOMTokenList* HTMLMediaElement::controlsList() const {
+  return m_controlsList.get();
+}
+
+void HTMLMediaElement::controlsListValueWasSet() {
+  // Update the attribute value which will update the controls visibility.
+  if (fastGetAttribute(controlsAttr) != m_controlsList->value()) {
+    setSynchronizedLazyAttribute(controlsAttr, m_controlsList->value());

[mlamouri (slow - plz ping), 2017/03/03 10:38:41]

I guess this needs to be updated?

[whywhat, 2017/03/03 16:04:55]

Yes, done.

+    updateControlsVisibility();
+  }
+}
+
 double HTMLMediaElement::volume() const {
   return m_volume;
 }
@@ -3823,6 +3838,7 @@ DEFINE_TRACE(HTMLMediaElement) {
   visitor->trace(m_srcObject);
   visitor->trace(m_autoplayVisibilityObserver);
   visitor->trace(m_mediaControls);
+  visitor->trace(m_controlsList);
   visitor->template registerWeakMembers<HTMLMediaElement,
                                         &HTMLMediaElement::clearWeakMembers>(
       this);