third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp - Issue 2657723002: [Blink, Media] Added controlsList to HTMLMediaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Issue 2657723002: [Blink, Media] Added controlsList to HTMLMediaElement (Closed)

Patch Set: Rebased and readded the tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLMediaElementControlsList.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLMediaElementControlsList.cpp ('k') | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

index 8bc5052f76bbfc6dbdc72146772a104c0f6a140d..306f210e5925869403a15d30526f579e71a174fe 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

@@ -700,6 +700,10 @@ bool MediaControlDownloadButtonElement::shouldDisplayDownloadButton() {

if (mediaElement().duration() == std::numeric_limits<double>::infinity())

return false;

+ // The attribute disables the download button.

+ if (mediaElement().controlsList()->tokens().contains("nodownload"))

+ return false;

mlamouri (slow - plz ping) 2017/03/03 17:32:44 Can you add a histogram that reports how many time

whywhat 2017/03/07 12:59:46 Done.

return true;

}