third_party/WebKit/LayoutTests/http/tests/media/controls-list-add-hide.html - Issue 2657723002: [Blink, Media] Added controlsList to HTMLMediaElement

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/media/controls-list-add-hide.html

Issue 2657723002: [Blink, Media] Added controlsList to HTMLMediaElement (Closed)

Patch Set: Added layout tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/media/controls-list-remove-show.html » ('j') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Test adding keywords to controlsList hides buttons</title>
	mlamouri (slow - plz ping) 2017/03/03 10:38:41 Can you put the tests in the controls/ directory? Can you put the tests in the controls/ directory? or create one if there isn't in the http/ folder. whywhat 2017/03/03 16:04:55 Done. Show quoted text On 2017/03/03 at 10:38:41, mlamouri wrote: > Can you put the tests in the controls/ directory? or create one if there isn't in the http/ folder. Done.
	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="../../media-resources/media-file.js"></script>

	6 <script src="../../media-resources/media-controls.js"></script>

	7 <video controls id="enabled-controls" width="500px"></video>

	8 <script>

	9 async_test(t => {

	10 var v = document.getElementById('enabled-controls');

	11

	12 v.addEventListener('canplaythrough', t.step_func(e => {

	13 assert_not_equals(getComputedStyle(fullscreenButton(v)).display, 'none');

	14 assert_not_equals(getComputedStyle(downloadButton(v)).display, 'none');

	15

	16 v.controlsList.add('nodownload');
	mlamouri (slow - plz ping) 2017/03/03 10:38:41 By which mechanism does this create a re-layout of By which mechanism does this create a re-layout of the controls? whywhat 2017/03/03 16:04:55 Each time it changes, controlsList object tells HT Show quoted text On 2017/03/03 at 10:38:41, mlamouri wrote: > By which mechanism does this create a re-layout of the controls? Each time it changes, controlsList object tells HTMLMediaElement it's updated and HTMLMediaElement updates controls visibility. Does this answer your question?
	17

	18 testRunner.layoutAndPaintAsyncThen(t.step_func(() => {

	19 assert_not_equals(getComputedStyle(fullscreenButton(v)).display, 'none');

	20 assert_equals(getComputedStyle(downloadButton(v)).display, 'none');

	21 v.controlsList.add('nofullscreen');

	22

	23 testRunner.layoutAndPaintAsyncThen(t.step_func_done(() => {

	24 assert_equals(getComputedStyle(fullscreenButton(v)).display, 'none');

	25 assert_equals(getComputedStyle(downloadButton(v)).display, 'none');

	26 }));

	27 }));

	28 }));

	29

	30 v.src = findMediaFile('video', 'resources/test');

	31 }, 'Test disabling controls on the video element with all controls.');

	32 </script>

OLD	NEW