[Blink, Media] Added controlsList to HTMLMediaElement

third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights
  * reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 414 matching lines @@
       m_playingRemotely(false),
       m_inOverlayFullscreenVideo(false),
       m_mostlyFillingViewport(false),
       m_audioTracks(this, AudioTrackList::create(*this)),
       m_videoTracks(this, VideoTrackList::create(*this)),
       m_textTracks(this, nullptr),
       m_audioSourceNode(nullptr),
       m_autoplayUmaHelper(AutoplayUmaHelper::create(this)),
       m_remotePlaybackClient(nullptr),
       m_autoplayVisibilityObserver(nullptr),
-      m_mediaControls(nullptr) {
+      m_mediaControls(nullptr),
+      m_controlsList(HTMLMediaElementControlsList::create(this)) {
   BLINK_MEDIA_LOG << "HTMLMediaElement(" << (void*)this << ")";
 
   m_lockedPendingUserGesture = computeLockedPendingUserGesture(document);
   m_lockedPendingUserGestureIfCrossOriginExperimentEnabled =
       isDocumentCrossOrigin(document);
 
   LocalFrame* frame = document.frame();
   if (frame) {
     m_remotePlaybackClient =
         frame->loader().client()->createWebRemotePlaybackClient(*this);
@@ skipping 110 matching lines @@
                     << ", srcAttr, old=" << params.oldValue
                     << ", new=" << params.newValue << ")";
     // Trigger a reload, as long as the 'src' attribute is present.
     if (!params.newValue.isNull()) {
       m_ignorePreloadNone = false;
       invokeLoadAlgorithm();
     }
   } else if (name == controlsAttr) {
     UseCounter::count(document(),
                       UseCounter::HTMLMediaElementControlsAttribute);
+    if (m_controlsList->value() != fastGetAttribute(controlsAttr))
+      m_controlsList->setValue(fastGetAttribute(controlsAttr));

[fs, 2017/01/25 09:34:16]

m_controlsList->setValue(params.newValue);

(and params.oldValue != params.newValue if you don't want to reset the attribute
per the below.)

[whywhat, 2017/03/01 16:17:20]

Done.

     updateControlsVisibility();
   } else if (name == preloadAttr) {
     setPlayerPreload();
   } else if (name == disableremoteplaybackAttr) {
     // This attribute is an extension described in the Remote Playback API spec.
     // Please see: https://w3c.github.io/remote-playback
     UseCounter::count(document(), UseCounter::DisableRemotePlaybackAttribute);
     if (params.oldValue != params.newValue) {
       if (m_webMediaPlayer) {
         m_webMediaPlayer->requestRemotePlaybackDisabled(
@@ skipping 1804 matching lines @@
     if (recordMetrics == RecordMetricsBehavior::DoRecord)
       showControlsHistogram().count(MediaControlsShowNoScript);
     return true;
   }
 
   if (recordMetrics == RecordMetricsBehavior::DoRecord)
     showControlsHistogram().count(MediaControlsShowNotShown);
   return false;
 }
 
+DOMTokenList* HTMLMediaElement::controlsList() const {
+  return m_controlsList.get();
+}
+
+void HTMLMediaElement::controlsListValueWasSet() {
+  // Update the attribute value which will update the controls visibility.
+  if (fastGetAttribute(controlsAttr) != m_controlsList->value())
+    setAttribute(controlsAttr, m_controlsList->value());

[fs, 2017/01/25 09:34:16]

Could (should?) use setSynchronizedLazyAttribute, which means you wouldn't
re-enter attributeChanged/parseAttribute if the call originated there.

[whywhat, 2017/03/01 16:17:20]

Done. Have to call updateControlsVisibility here.

+}
+
 double HTMLMediaElement::volume() const {
   return m_volume;
 }
 
 void HTMLMediaElement::setVolume(double vol, ExceptionState& exceptionState) {
   BLINK_MEDIA_LOG << "setVolume(" << (void*)this << ", " << vol << ")";
 
   if (m_volume == vol)
     return;
 
@@ skipping 1366 matching lines @@
   visitor->trace(m_textTracks);
   visitor->trace(m_textTracksWhenResourceSelectionBegan);
   visitor->trace(m_playPromiseResolvers);
   visitor->trace(m_playPromiseResolveList);
   visitor->trace(m_playPromiseRejectList);
   visitor->trace(m_audioSourceProvider);
   visitor->trace(m_autoplayUmaHelper);
   visitor->trace(m_srcObject);
   visitor->trace(m_autoplayVisibilityObserver);
   visitor->trace(m_mediaControls);
+  visitor->trace(m_controlsList);
   visitor->template registerWeakMembers<HTMLMediaElement,
                                         &HTMLMediaElement::clearWeakMembers>(
       this);
   Supplementable<HTMLMediaElement>::trace(visitor);
   HTMLElement::trace(visitor);
   SuspendableObject::trace(visitor);
 }
 
 DEFINE_TRACE_WRAPPERS(HTMLMediaElement) {
   visitor->traceWrappers(m_videoTracks);
@@ skipping 342 matching lines @@
       kMostlyFillViewportBecomeStableSeconds, BLINK_FROM_HERE);
 }
 
 void HTMLMediaElement::viewportFillDebouncerTimerFired(TimerBase*) {
   m_mostlyFillingViewport = true;
   if (m_webMediaPlayer)
     m_webMediaPlayer->becameDominantVisibleContent(m_mostlyFillingViewport);
 }
 
 }  // namespace blink