Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: components/ntp_snippets/sessions/tab_delegate_sync_adapter.cc

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)
Patch Set: Use parameter Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/sessions/tab_delegate_sync_adapter.cc
diff --git a/components/ntp_snippets/sessions/tab_delegate_sync_adapter.cc b/components/ntp_snippets/sessions/tab_delegate_sync_adapter.cc
index 8f7733d919069cb593d27adc42c8e5e491bb656c..59eda97672644ef0d0f185f113568e8300a894fb 100644
--- a/components/ntp_snippets/sessions/tab_delegate_sync_adapter.cc
+++ b/components/ntp_snippets/sessions/tab_delegate_sync_adapter.cc
@@ -44,7 +44,7 @@ void TabDelegateSyncAdapter::SubscribeForForeignTabChange(
change_callback_ = change_callback;
}
-void TabDelegateSyncAdapter::OnStateChanged() {
+void TabDelegateSyncAdapter::OnStateChanged(syncer::SyncService* sync) {
// OnStateChanged gets called very frequently, and usually is not important.
// But there are some events, like disabling sync and signing out, that are
// only captured through OnStateChange. In an attempt to send as few messages
@@ -62,14 +62,16 @@ void TabDelegateSyncAdapter::OnStateChanged() {
}
}
-void TabDelegateSyncAdapter::OnSyncConfigurationCompleted() {
+void TabDelegateSyncAdapter::OnSyncConfigurationCompleted(
+ syncer::SyncService* sync) {
// Ignored. This event can let us know when the set of enabled data types
// change. However, we want to avoid useless notifications as much as
// possible, and all of the information captured in this event will also be
// covered by OnStateChange.
}
-void TabDelegateSyncAdapter::OnForeignSessionUpdated() {
+void TabDelegateSyncAdapter::OnForeignSessionUpdated(
+ syncer::SyncService* sync) {
// Foreign tab data changed, always invoke the callback to generate new
// suggestions. Interestingly, this is only triggered after sync model type
// apply, not after merge. The merge case should always be handled by

Powered by Google App Engine
This is Rietveld 408576698