Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4375)

Unified Diff: chrome/browser/extensions/external_pref_loader.cc

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)
Patch Set: Use parameter Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/external_pref_loader.cc
diff --git a/chrome/browser/extensions/external_pref_loader.cc b/chrome/browser/extensions/external_pref_loader.cc
index 1d257b23a7c1e480860e363ffd4311e5bf0e4583..76c3c799d605b9ed29f7f170fec55d48d26b7ed5 100644
--- a/chrome/browser/extensions/external_pref_loader.cc
+++ b/chrome/browser/extensions/external_pref_loader.cc
@@ -154,11 +154,8 @@ void ExternalPrefLoader::OnIsSyncingChanged() {
PostLoadIfPrioritySyncReady();
}
-void ExternalPrefLoader::OnStateChanged() {
- browser_sync::ProfileSyncService* service =
- ProfileSyncServiceFactory::GetForProfile(profile_);
- DCHECK(service);
- if (!service->CanSyncStart()) {
+void ExternalPrefLoader::OnStateChanged(syncer::SyncService* sync) {
+ if (!sync->CanSyncStart()) {
sky 2017/01/27 16:29:44 remove {}
Steven Holte 2017/01/27 20:11:45 Done.
PostLoadAndRemoveObservers();
}
}

Powered by Google App Engine
This is Rietveld 408576698