ios/chrome/browser/desktop_promotion/desktop_promotion_sync_observer.cc - Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/desktop_promotion/desktop_promotion_sync_observer.cc

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)

Patch Set: Chromeos fix Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/desktop_promotion/desktop_promotion_sync_observer.h ('k') | ios/chrome/browser/sync/sync_observer_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/desktop_promotion/desktop_promotion_sync_observer.cc

diff --git a/ios/chrome/browser/desktop_promotion/desktop_promotion_sync_observer.cc b/ios/chrome/browser/desktop_promotion/desktop_promotion_sync_observer.cc

index 62208d02523761026290affda0f12c86a6361ed0..0188b287e147278da870e6f6c3d9c82a023c8d9d 100644

--- a/ios/chrome/browser/desktop_promotion/desktop_promotion_sync_observer.cc

+++ b/ios/chrome/browser/desktop_promotion/desktop_promotion_sync_observer.cc

@@ -38,7 +38,7 @@ DesktopPromotionSyncObserver::~DesktopPromotionSyncObserver() {

sync_service_->RemoveObserver(this);

}

-void DesktopPromotionSyncObserver::OnStateChanged() {

+void DesktopPromotionSyncObserver::OnStateChanged(syncer::SyncService* sync) {

if (desktop_metrics_logger_initiated_ ||

!sync_service_->GetActiveDataTypes().Has(syncer::PRIORITY_PREFERENCES)) {

return;