components/sync/driver/sync_service_base.cc - Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/driver/sync_service_base.cc

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)

Patch Set: Chromeos fix Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/driver/sync_service_base.cc

diff --git a/components/sync/driver/sync_service_base.cc b/components/sync/driver/sync_service_base.cc

index 10d41b314943e52a03452a658f03305afae1cb55..21ce7f665cbac5f5588220682d446b43fefa80b9 100644

--- a/components/sync/driver/sync_service_base.cc

+++ b/components/sync/driver/sync_service_base.cc

@@ -87,7 +87,7 @@ bool SyncServiceBase::HasObserver(const SyncServiceObserver* observer) const {

void SyncServiceBase::NotifyObservers() {

for (auto& observer : observers_) {

- observer.OnStateChanged();

+ observer.OnStateChanged(this);

}