components/suggestions/suggestions_service_impl_unittest.cc - Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/suggestions/suggestions_service_impl_unittest.cc

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)

Patch Set: Chromeos fix Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/suggestions/suggestions_service_impl_unittest.cc

diff --git a/components/suggestions/suggestions_service_impl_unittest.cc b/components/suggestions/suggestions_service_impl_unittest.cc

index bc3aafcfda6a5a1154f1aefe22d135517b4d0807..829c053691298cbe422799abc448eef9013089cc 100644

--- a/components/suggestions/suggestions_service_impl_unittest.cc

+++ b/components/suggestions/suggestions_service_impl_unittest.cc

@@ -398,7 +398,7 @@ TEST_F(SuggestionsServiceTest, FetchSuggestionsDataSyncDisabled) {

// Tell SuggestionsService that the sync state changed. The cache should be

// cleared and empty data returned to the callback.

- suggestions_service->OnStateChanged();

+ suggestions_service->OnStateChanged(mock_sync_service_.get());

// Ensure that CheckCallback ran once with empty data.

EXPECT_EQ(1, suggestions_data_callback_count_);