components/browsing_data/core/counters/history_counter.cc - Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browsing_data/core/counters/history_counter.cc

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)

Patch Set: Chromeos fix Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/browsing_data/core/counters/history_counter.cc

diff --git a/components/browsing_data/core/counters/history_counter.cc b/components/browsing_data/core/counters/history_counter.cc

index c1c44512ba0dcf2b820ef9a1f1220f58346c123c..daf801073c250aceb7a3f26b8986fdb4a5e8b708 100644

--- a/components/browsing_data/core/counters/history_counter.cc

+++ b/components/browsing_data/core/counters/history_counter.cc

@@ -158,7 +158,7 @@ HistoryCounter::HistoryResult::HistoryResult(const HistoryCounter* source,

HistoryCounter::HistoryResult::~HistoryResult() {}

-void HistoryCounter::OnStateChanged() {

+void HistoryCounter::OnStateChanged(syncer::SyncService* sync) {

bool history_sync_enabled_new_state = !!web_history_service_callback_.Run();

// If the history sync was just enabled or disabled, restart the counter