chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h - Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)

Patch Set: Chromeos fix Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/people_handler_unittest.cc ('k') | chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h

diff --git a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h

index 57b97f77a3ff4a7b2ed490d38b0656c2a3216a68..a713bff953139f5350c41577120ce89494693bba 100644

--- a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h

+++ b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h

@@ -54,9 +54,11 @@ class ClearBrowsingDataHandler : public SettingsPageUIHandler,

// Initializes the dialog UI. Called by JavaScript when the DOM is ready.

void HandleInitialize(const base::ListValue* args);

- // Implementation of SyncServiceObserver. Updates the footer of the dialog

- // when the sync state changes.

- void OnStateChanged() override;

+ // Implementation of SyncServiceObserver.

+ void OnStateChanged(syncer::SyncService* sync) override;

+ // Updates the footer of the dialog when the sync state changes.

+ void UpdateSyncState();

// Finds out whether we should show notice about other forms of history stored

// in user's account.