chrome/browser/sync/test/integration/quiesce_status_change_checker.cc - Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/quiesce_status_change_checker.cc

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)

Patch Set: Chromeos fix Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/p2p_sync_refresher.cc ('k') | chrome/browser/sync_file_system/sync_file_system_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/quiesce_status_change_checker.cc

diff --git a/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc b/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc

index 53b65fc63516b77ac6eae8a9ebdffa2dcd713a1f..096e9dad06e667ad62596d81fda2b3fac0a4e042 100644

--- a/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc

+++ b/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc

@@ -79,7 +79,7 @@ class ProgressMarkerWatcher : public syncer::SyncServiceObserver {

ProgressMarkerWatcher(browser_sync::ProfileSyncService* service,

QuiesceStatusChangeChecker* quiesce_checker);

~ProgressMarkerWatcher() override;

- void OnStateChanged() override;

+ void OnStateChanged(syncer::SyncService* sync) override;

bool HasLatestProgressMarkers();

bool IsSyncDisabled();

@@ -107,7 +107,7 @@ ProgressMarkerWatcher::ProgressMarkerWatcher(

ProgressMarkerWatcher::~ProgressMarkerWatcher() { }

-void ProgressMarkerWatcher::OnStateChanged() {

+void ProgressMarkerWatcher::OnStateChanged(syncer::SyncService* sync) {

UpdateHasLatestProgressMarkers();

quiesce_checker_->OnServiceStateChanged(service_);

}