Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: components/suggestions/suggestions_service_impl.cc

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)
Patch Set: Add SyncService* to OnStateChanged Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/suggestions/suggestions_service_impl.cc
diff --git a/components/suggestions/suggestions_service_impl.cc b/components/suggestions/suggestions_service_impl.cc
index 5f30527c68bed1804c66139fcf5e696ebfa879bf..a556436353285c6bd931f6b56ceacbf5a6f6f1a4 100644
--- a/components/suggestions/suggestions_service_impl.cc
+++ b/components/suggestions/suggestions_service_impl.cc
@@ -209,7 +209,7 @@ SuggestionsServiceImpl::SuggestionsServiceImpl(
sync_service_observer_.Add(sync_service_);
// Immediately get the current sync state, so we'll flush the cache if
// necessary.
- OnStateChanged();
+ OnStateChanged(NULL);
skym 2017/01/26 23:43:23 nullptr
Steven Holte 2017/01/27 02:27:19 Changed to sync_service_
}
SuggestionsServiceImpl::~SuggestionsServiceImpl() {}
@@ -348,7 +348,7 @@ GURL SuggestionsServiceImpl::BuildSuggestionsBlacklistClearURL() {
kDeviceType));
}
-void SuggestionsServiceImpl::OnStateChanged() {
+void SuggestionsServiceImpl::OnStateChanged(syncer::SyncService* sync) {
switch (GetSyncState(sync_service_)) {
case SYNC_OR_HISTORY_SYNC_DISABLED:
// Cancel any ongoing request, to stop interacting with the server.

Powered by Google App Engine
This is Rietveld 408576698