components/history/core/browser/history_delete_directives_data_type_controller.h - Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_delete_directives_data_type_controller.h

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)

Patch Set: Add SyncService* to OnStateChanged Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc ('K') | « components/browsing_data/core/counters/history_counter.cc ('k') | components/history/core/browser/history_delete_directives_data_type_controller.cc » ('j') | components/suggestions/suggestions_service_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/history/core/browser/history_delete_directives_data_type_controller.h

diff --git a/components/history/core/browser/history_delete_directives_data_type_controller.h b/components/history/core/browser/history_delete_directives_data_type_controller.h

index a000181eec4d2b6fc6c0e55ed535e543e3ef83b6..c676515a807078cf2eb4d9af802b53cea9d5615a 100644

--- a/components/history/core/browser/history_delete_directives_data_type_controller.h

+++ b/components/history/core/browser/history_delete_directives_data_type_controller.h

@@ -29,7 +29,7 @@ class HistoryDeleteDirectivesDataTypeController

void StopModels() override;

// syncer::SyncServiceObserver implementation.

- void OnStateChanged() override;

+ void OnStateChanged(syncer::SyncService* sync) override;

private:

// Triggers a SingleDataTypeUnrecoverable error and returns true if the