chrome/browser/ui/webui/options/clear_browser_data_handler.cc - Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/clear_browser_data_handler.cc

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)

Patch Set: Add SyncService* to OnStateChanged Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options/clear_browser_data_handler.cc

diff --git a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc

index 0d7767128d979c0671e706dc878005b1a2bc1c33..9ff78dcff54793ca8333258084ece69e6bc21967 100644

--- a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc

+++ b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc

@@ -391,7 +391,7 @@ void ClearBrowserDataHandler::UpdateCounterText(

base::StringValue(GetChromeCounterTextFromResult(result.get())));

}

-void ClearBrowserDataHandler::OnStateChanged() {

+void ClearBrowserDataHandler::OnStateChanged(syncer::SyncService* sync) {

web_ui()->CallJavascriptFunctionUnsafe(

"ClearBrowserDataOverlay.updateSyncWarningAndHistoryFooter",

base::FundamentalValue(sync_service_ && sync_service_->IsSyncActive()),