components/ntp_snippets/sessions/tab_delegate_sync_adapter_unittest.cc - Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/sessions/tab_delegate_sync_adapter_unittest.cc

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/browser_sync/profile_sync_service.cc ('K') | « components/ntp_snippets/sessions/tab_delegate_sync_adapter.cc ('k') | components/sync/driver/sync_service_observer.h » ('j') | components/sync/driver/sync_service_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/sessions/tab_delegate_sync_adapter_unittest.cc

diff --git a/components/ntp_snippets/sessions/tab_delegate_sync_adapter_unittest.cc b/components/ntp_snippets/sessions/tab_delegate_sync_adapter_unittest.cc

index b10c7d56f093f308f89710855367f5c2d4df8d4b..99299d80ee7bbd960c754077793a886a24c142b3 100644

--- a/components/ntp_snippets/sessions/tab_delegate_sync_adapter_unittest.cc

+++ b/components/ntp_snippets/sessions/tab_delegate_sync_adapter_unittest.cc

@@ -114,11 +114,11 @@ TEST_F(TabDelegateSyncAdapterTest, CallbackCount) {

TEST_F(TabDelegateSyncAdapterTest, OnSyncConfigurationCompleted) {

ASSERT_EQ(0, CallbackCount());

- observer()->OnSyncConfigurationCompleted();

+ observer()->OnSyncConfigurationCompleted(&service_);

EXPECT_EQ(0, CallbackCount());

SetHasOpenTabs(true);

- observer()->OnSyncConfigurationCompleted();

+ observer()->OnSyncConfigurationCompleted(&service_);

EXPECT_EQ(0, CallbackCount());

}