Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: components/ntp_snippets/sessions/tab_delegate_sync_adapter_unittest.cc

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_snippets/sessions/tab_delegate_sync_adapter.h" 5 #include "components/ntp_snippets/sessions/tab_delegate_sync_adapter.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "components/sync/driver/fake_sync_service.h" 10 #include "components/sync/driver/fake_sync_service.h"
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 observer()->OnSyncCycleCompleted(); 107 observer()->OnSyncCycleCompleted();
108 EXPECT_EQ(3, CallbackCount()); 108 EXPECT_EQ(3, CallbackCount());
109 observer()->OnSyncCycleCompleted(); 109 observer()->OnSyncCycleCompleted();
110 EXPECT_EQ(3, CallbackCount()); 110 EXPECT_EQ(3, CallbackCount());
111 } 111 }
112 112
113 // No callback should be invoked from OnSyncConfigurationCompleted. 113 // No callback should be invoked from OnSyncConfigurationCompleted.
114 TEST_F(TabDelegateSyncAdapterTest, OnSyncConfigurationCompleted) { 114 TEST_F(TabDelegateSyncAdapterTest, OnSyncConfigurationCompleted) {
115 ASSERT_EQ(0, CallbackCount()); 115 ASSERT_EQ(0, CallbackCount());
116 116
117 observer()->OnSyncConfigurationCompleted(); 117 observer()->OnSyncConfigurationCompleted(&service_);
118 EXPECT_EQ(0, CallbackCount()); 118 EXPECT_EQ(0, CallbackCount());
119 119
120 SetHasOpenTabs(true); 120 SetHasOpenTabs(true);
121 observer()->OnSyncConfigurationCompleted(); 121 observer()->OnSyncConfigurationCompleted(&service_);
122 EXPECT_EQ(0, CallbackCount()); 122 EXPECT_EQ(0, CallbackCount());
123 } 123 }
124 124
125 // OnForeignSessionUpdated should always trigger a callback. 125 // OnForeignSessionUpdated should always trigger a callback.
126 TEST_F(TabDelegateSyncAdapterTest, OnForeignSessionUpdated) { 126 TEST_F(TabDelegateSyncAdapterTest, OnForeignSessionUpdated) {
127 ASSERT_EQ(0, CallbackCount()); 127 ASSERT_EQ(0, CallbackCount());
128 observer()->OnForeignSessionUpdated(); 128 observer()->OnForeignSessionUpdated();
129 EXPECT_EQ(1, CallbackCount()); 129 EXPECT_EQ(1, CallbackCount());
130 observer()->OnForeignSessionUpdated(); 130 observer()->OnForeignSessionUpdated();
131 EXPECT_EQ(2, CallbackCount()); 131 EXPECT_EQ(2, CallbackCount());
(...skipping 11 matching lines...) Expand all
143 SetHasOpenTabs(true); 143 SetHasOpenTabs(true);
144 observer()->OnForeignSessionUpdated(); 144 observer()->OnForeignSessionUpdated();
145 EXPECT_EQ(1, CallbackCount()); 145 EXPECT_EQ(1, CallbackCount());
146 146
147 observer()->OnStateChanged(); 147 observer()->OnStateChanged();
148 EXPECT_EQ(1, CallbackCount()); 148 EXPECT_EQ(1, CallbackCount());
149 } 149 }
150 150
151 } // namespace 151 } // namespace
152 } // namespace ntp_snippets 152 } // namespace ntp_snippets
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698