Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 265763011: Land recent SPDY changes (through 66310528) (Closed)

Created:
6 years, 7 months ago by Johnny
Modified:
6 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Land recent SPDY changes (through 66310528) SPDY size utility method. Small change from larger upstream CL working on plumbing SpdyHeaderBlockParser. This lands server change 65367667 by birenroy. https://codereview.chromium.org/267113005/ SPDY: Remove redundant end_push_promise and end_headers fields. Removed from SpdyPushPromiseIR and SpdyHeadersIR. No behavior changes. This lands server change 66127638 by mlavan. https://codereview.chromium.org/263033007/ HPACK changes required for specification draft '07 * The static Huffman table has been updated. * The static header table has been updated. * Several opcodes have been reordered, and have new wire formats. * New never-indexed opcode is decoded (but not encoded). Also removed tolerance for variations in "cookie" casing, to match current consensus on strict header name casing. This lands server change 66241100 by jgraettinger. https://codereview.chromium.org/269183008/ Allocate HpackDecoder/Encoder only for SpdyFramer > SPDY3. This lands server change 66310528 by jgraettinger. https://codereview.chromium.org/267063006/ BUG=339578, 345769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+687 lines, -617 lines) Patch
D net/data/spdy_tests/examples.hpack View Binary file 0 comments Download
A net/data/spdy_tests/examples_07.hpack View Binary file 0 comments Download
M net/spdy/fuzzing/hpack_fuzz_util_test.cc View 4 chunks +10 lines, -6 lines 0 comments Download
M net/spdy/hpack_constants.h View 2 chunks +22 lines, -23 lines 0 comments Download
M net/spdy/hpack_constants.cc View 1 chunk +258 lines, -257 lines 0 comments Download
M net/spdy/hpack_decoder.h View 2 chunks +3 lines, -4 lines 0 comments Download
M net/spdy/hpack_decoder.cc View 7 chunks +15 lines, -17 lines 0 comments Download
M net/spdy/hpack_decoder_test.cc View 25 chunks +182 lines, -120 lines 0 comments Download
M net/spdy/hpack_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_encoder_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/hpack_entry.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_header_table.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_header_table.cc View 1 chunk +52 lines, -51 lines 0 comments Download
M net/spdy/hpack_huffman_table_test.cc View 3 chunks +16 lines, -13 lines 0 comments Download
M net/spdy/hpack_input_stream.h View 3 chunks +3 lines, -8 lines 0 comments Download
M net/spdy/hpack_input_stream.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M net/spdy/hpack_input_stream_test.cc View 6 chunks +19 lines, -16 lines 0 comments Download
M net/spdy/hpack_output_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_string_util.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_frame_builder_test.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/spdy/spdy_framer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_framer.cc View 11 chunks +25 lines, -29 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 22 chunks +46 lines, -46 lines 0 comments Download
M net/spdy/spdy_protocol.h View 3 chunks +5 lines, -11 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/spdy/spdy_test_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/spdy/spdy_test_utils.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Johnny
6 years, 7 months ago (2014-05-06 22:01:52 UTC) #1
Ryan Hamilton
lgtm
6 years, 7 months ago (2014-05-06 22:28:39 UTC) #2
Johnny
The CQ bit was checked by jgraettinger@chromium.org
6 years, 7 months ago (2014-05-06 23:55:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/265763011/20001
6 years, 7 months ago (2014-05-06 23:57:38 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 06:04:26 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #2). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 12:27:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-07 12:32:28 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium android_clang_dbg on tryserver.chromium chromium_presubmit on tryserver.chromium ...
6 years, 7 months ago (2014-05-07 12:32:29 UTC) #8
Johnny
The CQ bit was checked by jgraettinger@chromium.org
6 years, 7 months ago (2014-05-07 16:57:43 UTC) #9
Johnny
The CQ bit was unchecked by jgraettinger@chromium.org
6 years, 7 months ago (2014-05-07 16:57:44 UTC) #10
Johnny
The CQ bit was checked by jgraettinger@chromium.org
6 years, 7 months ago (2014-05-07 21:18:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/265763011/20001
6 years, 7 months ago (2014-05-07 21:20:18 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 00:40:35 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 03:37:08 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 03:41:08 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium linux_chromium_chromeos_clang_dbg on tryserver.chromium linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 7 months ago (2014-05-08 03:41:09 UTC) #16
Johnny
The CQ bit was checked by jgraettinger@chromium.org
6 years, 7 months ago (2014-05-13 21:22:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/265763011/40001
6 years, 7 months ago (2014-05-13 21:24:39 UTC) #18
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 00:26:15 UTC) #19
Message was sent while issue was closed. 
Change committed as 270264

Powered by Google App Engine
This is Rietveld 408576698