Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: extensions/renderer/api_last_error.h

Issue 2657613005: [Extensions Bindings] Add chrome.runtime.lastError support (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api_last_error.h
diff --git a/extensions/renderer/api_last_error.h b/extensions/renderer/api_last_error.h
new file mode 100644
index 0000000000000000000000000000000000000000..78ce0e45dcef3292089d6d17e20fc2c20a46d396
--- /dev/null
+++ b/extensions/renderer/api_last_error.h
@@ -0,0 +1,44 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_RENDERER_API_LAST_ERROR_H_
+#define EXTENSIONS_RENDERER_API_LAST_ERROR_H_
+
+#include <string>
+
+#include "base/callback.h"
+#include "base/macros.h"
+#include "v8/include/v8.h"
+
+namespace extensions {
+
+// Handles creating and clearing a 'lastError' property to hold the last error
+// set by an extension API function.
+class APILastError {
+ public:
+ // Returns the object the 'lastError' property should be exposed on for the
+ // given context.
+ using GetParent =
+ base::Callback<v8::Local<v8::Object>(v8::Local<v8::Context>)>;
+
+ APILastError(const GetParent& get_parent);
jbroman 2017/02/13 19:41:27 explicit
Devlin 2017/02/14 04:57:08 Done.
+ APILastError(APILastError&& other);
jbroman 2017/02/13 19:41:27 It's a little weird to have a move constructor wit
Devlin 2017/02/14 04:57:08 Right. Not sure if we have a preferred style here
+ ~APILastError();
+
+ // Sets the last error for the given |context| to |error|.
+ void SetError(v8::Local<v8::Context> context, const std::string& error);
+
+ // Clears the last error in the given |context|. If |report_if_unchecked| is
+ // true and the developer didn't check the error, this throws an exception.
+ void ClearError(v8::Local<v8::Context> context, bool report_if_unchecked);
+
+ private:
+ GetParent get_parent_;
+
+ DISALLOW_COPY_AND_ASSIGN(APILastError);
+};
+
+} // namespace extensions
+
+#endif // EXTENSIONS_RENDERER_API_LAST_ERROR_H_

Powered by Google App Engine
This is Rietveld 408576698