Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: extensions/renderer/api_bindings_system.cc

Issue 2657613005: [Extensions Bindings] Add chrome.runtime.lastError support (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api_bindings_system.cc
diff --git a/extensions/renderer/api_bindings_system.cc b/extensions/renderer/api_bindings_system.cc
index 040d62027082d5665a7a43079c6344b8a4238b08..d537dbc0c973cadf178af544db8b10ad60d8572d 100644
--- a/extensions/renderer/api_bindings_system.cc
+++ b/extensions/renderer/api_bindings_system.cc
@@ -16,8 +16,9 @@ APIBindingsSystem::APIBindingsSystem(
const binding::RunJSFunctionSync& call_js_sync,
const GetAPISchemaMethod& get_api_schema,
const APIBinding::SendRequestMethod& send_request,
- const APIEventHandler::EventListenersChangedMethod& event_listeners_changed)
- : request_handler_(call_js),
+ const APIEventHandler::EventListenersChangedMethod& event_listeners_changed,
+ APILastError last_error)
+ : request_handler_(call_js, std::move(last_error)),
event_handler_(call_js, event_listeners_changed),
call_js_(call_js),
call_js_sync_(call_js_sync),
@@ -71,8 +72,9 @@ std::unique_ptr<APIBinding> APIBindingsSystem::CreateNewAPIBinding(
}
void APIBindingsSystem::CompleteRequest(int request_id,
- const base::ListValue& response) {
- request_handler_.CompleteRequest(request_id, response);
+ const base::ListValue& response,
+ const std::string& error) {
+ request_handler_.CompleteRequest(request_id, response, error);
}
void APIBindingsSystem::FireEventInContext(const std::string& event_name,

Powered by Google App Engine
This is Rietveld 408576698