Issue 2657583007: Record isFinal for parameters into summaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2657583007: Record isFinal for parameters into summaries. (Closed)

Created:
3 years, 10 months ago by scheglov

Modified:
3 years, 10 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Record isFinal for parameters into summaries. Found this out while running shared tests with the new analysis driver. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4cd790abe3b1dd9c10e591056870dd0c064f8135

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -2 lines)			Patch
M	pkg/analyzer/lib/src/dart/element/element.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/summary/format.dart	View	10 chunks	+26 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/summary/format.fbs	View	Binary file		0 comments	Download
M	pkg/analyzer/lib/src/summary/idl.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/summarize_ast.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/static_warning_code_test.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/summary_common.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Paul Berry

On 2017/01/25 22:53:46, scheglov wrote: Can you add a resynthesis test to make sure that ...

3 years, 10 months ago (2017-01-25 23:00:31 UTC) #2

scheglov

3 years, 10 months ago (2017-01-25 23:08:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4cd790abe3b1dd9c10e591056870dd0c064f8135 (presubmit successful).