Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2657533004: Update MockSdk to be more consistent with the actual SDK, switch x_Driver tests to it. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update MockSdk to be more consistent with the actual SDK, switch x_Driver tests to it. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/207dc4a5a1f6872f7ec68d97a7e770576297d6cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -41 lines) Patch
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +0 lines, -13 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/context/mock_sdk.dart View 11 chunks +76 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/base.dart View 3 chunks +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 4 chunks +4 lines, -1 line 0 comments Download
D pkg/analyzer/test/src/dart/analysis/physical_sdk.dart View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-24 20:41:49 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-24 20:47:10 UTC) #2
scheglov
3 years, 11 months ago (2017-01-24 20:53:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
207dc4a5a1f6872f7ec68d97a7e770576297d6cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698