[stubs] Add initializing constructor to CSA::Variable

src/compiler/code-assembler.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/code-assembler.h"
 
 #include <ostream>
 
 #include "src/code-factory.h"
 #include "src/compiler/graph.h"
@@ skipping 682 matching lines @@
   Node* value_;
   MachineRepresentation rep_;
 };
 
 CodeAssemblerVariable::CodeAssemblerVariable(CodeAssembler* assembler,
                                              MachineRepresentation rep)
     : impl_(new (assembler->zone()) Impl(rep)), state_(assembler->state()) {
   state_->variables_.insert(impl_);
 }
 
+CodeAssemblerVariable::CodeAssemblerVariable(CodeAssembler* assembler,
+                                             MachineRepresentation rep,
+                                             Node* initial_value)
+    : impl_(new (assembler->zone()) Impl(rep)), state_(assembler->state()) {

[Igor Sheludko, 2017/01/24 15:10:31]

I think it's better to implement it as:
  : CodeAssemblerVariable(assembler, rep) {
  Bind(initial_value);
}

[jgruber, 2017/01/24 15:16:26]

Done.

+  state_->variables_.insert(impl_);
+  Bind(initial_value);
+}
+
 CodeAssemblerVariable::~CodeAssemblerVariable() {
   state_->variables_.erase(impl_);
 }
 
 void CodeAssemblerVariable::Bind(Node* value) { impl_->value_ = value; }
 
 Node* CodeAssemblerVariable::value() const {
   DCHECK_NOT_NULL(impl_->value_);
   return impl_->value_;
 }
@@ skipping 120 matching lines @@
       }
     }
   }
 
   bound_ = true;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8