Mojo: Factor MessageInTransit secondary buffer stuff out into a separate class.

Mojo: Factor MessageInTransit secondary buffer stuff out into a separate class.

Also write a big comment explaining what I'm going to do.

R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268032

[viettrungluu, 2014-05-02 22:32:58]

ping

[darin (slow to review), 2014-05-02 22:51:40]

LGTM

https://codereview.chromium.org/265753006/diff/1/mojo/system/transport_data.cc
File mojo/system/transport_data.cc (right):

https://codereview.chromium.org/265753006/diff/1/mojo/system/transport_data.c...
mojo/system/transport_data.cc:33: struct
TransportData::PrivateStructForCompileAsserts {
neat, i hadn't considered such a pattern for compile asserts

https://codereview.chromium.org/265753006/diff/1/mojo/system/transport_data.c...
mojo/system/transport_data.cc:256: #if 0
nit!

https://codereview.chromium.org/265753006/diff/1/mojo/system/transport_data.h
File mojo/system/transport_data.h (right):

https://codereview.chromium.org/265753006/diff/1/mojo/system/transport_data.h...
mojo/system/transport_data.h:83:
scoped_ptr<std::vector<scoped_refptr<Dispatcher> > > dispatchers,
maybe a typedef would be helpful here

[viettrungluu, 2014-05-03 00:12:49]

Thanks.

https://codereview.chromium.org/265753006/diff/1/mojo/system/transport_data.cc
File mojo/system/transport_data.cc (right):

https://codereview.chromium.org/265753006/diff/1/mojo/system/transport_data.c...
mojo/system/transport_data.cc:256: #if 0
On 2014/05/02 22:51:40, darin wrote:
> nit!

Oops!

https://codereview.chromium.org/265753006/diff/1/mojo/system/transport_data.h
File mojo/system/transport_data.h (right):

https://codereview.chromium.org/265753006/diff/1/mojo/system/transport_data.h...
mojo/system/transport_data.h:83:
scoped_ptr<std::vector<scoped_refptr<Dispatcher> > > dispatchers,
On 2014/05/02 22:51:40, darin wrote:
> maybe a typedef would be helpful here

Good idea. I'll do it separately though, since apparently I have A LOT of
std::vector<scoped_refptr<Dispatcher> >s. (I can't believe I've put up with
typing that for so long.)

[viettrungluu, 2014-05-03 00:12:53]

The CQ bit was checked by viettrungluu@chromium.org

[commit-bot: I haz the power, 2014-05-03 00:13:02]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/265753006/20001

[commit-bot: I haz the power, 2014-05-03 03:40:27]

Change committed as 268032