Add support for type checking of floating point attributes

Source/modules/mediasource/SourceBuffer.idl

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+// https://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html#idl-def-SourceBuffer
+
 enum AppendMode {
     "segments",
     "sequence"
 };
 
 [
+    ActiveDOMObject,
     NoInterfaceObject,
-    ActiveDOMObject,
-    RuntimeEnabled=MediaSource
+    RuntimeEnabled=MediaSource,
 ] interface SourceBuffer : EventTarget {
 
     // Gets or sets the AppendMode.
     // FIXME: Remove MediaSourceExperimental once mode attribute is implemented and stabilized. See http://crbug.com/249422.
     [RaisesException=Setter, RuntimeEnabled=MediaSourceExperimental] attribute AppendMode mode;
 
     readonly attribute boolean updating;
 
     // Returns the time ranges buffered.
     [RaisesException=Getter] readonly attribute TimeRanges buffered;
 
     // Applies an offset to media segment timestamps.
-    [RaisesException=Setter] attribute double timestampOffset;
+    [RaisesException=Setter, TypeChecking=Unrestricted] attribute double timestampOffset;
 
     // Presentation timestamp for the start of append window.
-    [RaisesException=Setter] attribute double appendWindowStart;
+    [RaisesException=Setter, TypeChecking=Unrestricted] attribute double appendWindowStart;
 
     // Presentation timestamp for the end of append window.
-    [RaisesException=Setter] attribute double appendWindowEnd;
+    [RaisesException=Setter, TypeChecking=Unrestricted] attribute unrestricted double appendWindowEnd;

[haraken, 2014/05/01 03:25:58]

I'm a bit confused. What's the difference between:

- double x;
- unrestricted double x;
- [TypeChecking=Unrestricted] double x;
- [TypeChecking=Unrestricted] unrestricted double x;

?

[Nils Barth (inactive), 2014/05/01 03:34:26]

Behavior-wise, currently only:
[TypeChecking=Unrestricted] double x;
...has type-checking for non-finite values.
(For compatibility.)

However, [TypeChecking=Unrestricted] should go on the *interface*, in which case
attribute double x;
attribute unrestricted double x;
...*do* differ (attribute double x; is type-checked), and we have to get them
right.

The:
[TypeChecking=Unrestricted] attribute unrestricted double x;
...in this CL asserts that we've checked this attribute, so it'll be easy to
move the [TypeChecking=Unrestricted] to the interface (once methods are also
checked).

I'm just adding test cases here; Fredrik is doing full type-checking in:
Apply TypeChecking to MediaSource IDLs
https://codereview.chromium.org/266453005/

Make sense?

 
     // Append segment data.
     [RaisesException] void appendBuffer(ArrayBuffer data);
     [RaisesException] void appendBuffer(ArrayBufferView data);
 
     [RaisesException, RuntimeEnabled=Stream] void appendStream(Stream stream, optional unsigned long long maxSize);
 
     // Abort the current segment append sequence.
     [RaisesException] void abort();
     [RaisesException] void remove(double start, double end);
 };