Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2467)

Unified Diff: sdk/lib/io/http_parser.dart

Issue 26575004: Rename error to _reportError in HttpParser. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/http_parser.dart
diff --git a/sdk/lib/io/http_parser.dart b/sdk/lib/io/http_parser.dart
index d885008b05ae0e746a66bee7b391a06ff7def8b7..4acc0132d26d1ab396d9bbef1f03a4fbc550d1a5 100644
--- a/sdk/lib/io/http_parser.dart
+++ b/sdk/lib/io/http_parser.dart
@@ -256,7 +256,7 @@ class _HttpParser
_doParse();
} catch (e, s) {
_state = _State.FAILURE;
- error(e, s);
+ _reportError(e, s);
}
}
@@ -737,7 +737,7 @@ class _HttpParser
// If the connection is idle the HTTP stream is closed.
if (_state == _State.START) {
if (!_requestParser) {
- error(new HttpException(
+ _reportError(new HttpException(
"Connection closed before full header was received"));
}
_controller.close();
@@ -753,7 +753,7 @@ class _HttpParser
_state = _State.FAILURE;
// Report the error through the error callback if any. Otherwise
// throw the error.
- error(new HttpException(
+ _reportError(new HttpException(
"Connection closed before full header was received"));
_controller.close();
return;
@@ -765,7 +765,7 @@ class _HttpParser
_state = _State.FAILURE;
// Report the error through the error callback if any. Otherwise
// throw the error.
- error(new HttpException(
+ _reportError(new HttpException(
"Connection closed before full body was received"));
}
_controller.close();
@@ -945,7 +945,7 @@ class _HttpParser
}
}
- void error(error, [stackTrace]) {
+ void _reportError(error, [stackTrace]) {
if (_socketSubscription != null) _socketSubscription.cancel();
_state = _State.FAILURE;
_controller.addError(error, stackTrace);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698