Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: pkg/compiler/lib/src/ssa/optimize.dart

Issue 2657453004: dart2js: Redo known-type analysis after load-elimination (Closed)
Patch Set: fix comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/optimize.dart
diff --git a/pkg/compiler/lib/src/ssa/optimize.dart b/pkg/compiler/lib/src/ssa/optimize.dart
index b7b0c0ac5b2bc9e668d10487bfbfc1021d9043d6..9d8e316ec937ed6e13a8dbff23019cb446b40a10 100644
--- a/pkg/compiler/lib/src/ssa/optimize.dart
+++ b/pkg/compiler/lib/src/ssa/optimize.dart
@@ -88,6 +88,10 @@ class SsaOptimizerTask extends CompilerTask {
new SsaLoadElimination(compiler, closedWorld),
new SsaRedundantPhiEliminator(),
new SsaDeadPhiEliminator(),
+ // After GVN and load elimination the same value may be used in code
+ // controlled by a test on the value, so redo 'conversion insertion' to
+ // learn from the refined type.
+ new SsaTypeConversionInserter(closedWorld),
new SsaTypePropagator(compiler, closedWorld),
new SsaValueRangeAnalyzer(backend.helpers, closedWorld, this),
// Previous optimizations may have generated new
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698