Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 265743010: Use [TypeChecking=Unrestricted] for MediaController (Closed)

Created:
6 years, 7 months ago by philipj_slow
Modified:
6 years, 7 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, philipj_slow, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Use [TypeChecking=Unrestricted] for MediaController BUG=354298 TBR=acolwell Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -55 lines) Patch
M LayoutTests/media/media-controller-playback.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/media/media-controller-playback-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/media/media-controller-playbackrate.html View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/media/media-controller-playbackrate-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/media/media-controller-volume.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/media/media-controller-volume-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/MediaController.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/MediaController.cpp View 4 chunks +2 lines, -26 lines 0 comments Download
M Source/core/html/MediaController.idl View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
6 years, 7 months ago (2014-05-01 22:01:42 UTC) #1
Nils Barth (inactive)
LGTM
6 years, 7 months ago (2014-05-02 00:55:07 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-02 00:55:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/265743010/1
6 years, 7 months ago (2014-05-02 00:55:44 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 01:08:26 UTC) #5
Message was sent while issue was closed.
Change committed as 173148

Powered by Google App Engine
This is Rietveld 408576698