Always install a BookmarkUndoService as a BookmarkModelObserver on iOS

Always install a BookmarkUndoService as a BookmarkModelObserver on iOS

Chrome on iOS always need to have a BookmarkUndoService installed
as an observer to all the BookmarkModel (there is no command-line
switch on iOS).

BUG=364044
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268284

[blundell, 2014-05-05 13:08:15]

https://codereview.chromium.org/265743004/diff/1/chrome/browser/bookmarks/boo...
File chrome/browser/bookmarks/bookmark_model_factory.cc (right):

https://codereview.chromium.org/265743004/diff/1/chrome/browser/bookmarks/boo...
chrome/browser/bookmarks/bookmark_model_factory.cc:73: bool
register_bookmark_undo_service_as_observer = true;
I think this would be less confusing with this line hoisted up to be underneath
line 67 and no else clause in the "if !defined(OS_IOS)" block.

[noyau (Ping after 24h), 2014-05-05 13:40:24]

lgtm

[sdefresne, 2014-05-05 14:37:11]

PTAL

https://codereview.chromium.org/265743004/diff/1/chrome/browser/bookmarks/boo...
File chrome/browser/bookmarks/bookmark_model_factory.cc (right):

https://codereview.chromium.org/265743004/diff/1/chrome/browser/bookmarks/boo...
chrome/browser/bookmarks/bookmark_model_factory.cc:73: bool
register_bookmark_undo_service_as_observer = true;
On 2014/05/05 13:08:15, blundell wrote:
> I think this would be less confusing with this line hoisted up to be
underneath
> line 67 and no else clause in the "if !defined(OS_IOS)" block.

Done.

[blundell, 2014-05-05 14:40:44]

LGTM

[sdefresne, 2014-05-05 17:54:15]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-05-05 17:55:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sdefresne@chromium.org/265743004/20001

[commit-bot: I haz the power, 2014-05-05 21:55:10]

Change committed as 268284