Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Unified Diff: build/android/pylib/device/device_utils.py

Issue 265743002: [Android] Switch to new interfaces of GetAVDs and RestartAdbServer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/device/device_errors.py ('k') | build/android/pylib/device/device_utils_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/device/device_utils.py
diff --git a/build/android/pylib/device/device_utils.py b/build/android/pylib/device/device_utils.py
index 93e364eb426599cdcd32abc69fc1ce9122f3f96d..1440961aa5ec8f31b0a8dc88aab4a945a5dec3a5 100644
--- a/build/android/pylib/device/device_utils.py
+++ b/build/android/pylib/device/device_utils.py
@@ -7,12 +7,15 @@ Provides a variety of device interactions based on adb.
Eventually, this will be based on adb_wrapper.
"""
+# pylint: disable=W0613
import multiprocessing
import os
import sys
+
import pylib.android_commands
from pylib.device import adb_wrapper
+from pylib.device import decorators
CHROME_SRC_DIR = os.path.abspath(
os.path.join(os.path.dirname(__file__), '..', '..', '..', '..'))
@@ -20,8 +23,8 @@ sys.path.append(os.path.join(
CHROME_SRC_DIR, 'third_party', 'android_testrunner'))
import errors
-def GetAVDs():
- return pylib.android_commands.GetAVDs()
+_DEFAULT_TIMEOUT = 30
+_DEFAULT_RETRIES = 3
# multiprocessing map_async requires a top-level function for pickle library.
@@ -51,6 +54,28 @@ def RebootDevices():
print 'Reboots complete.'
+@decorators.WithExplicitTimeoutAndRetries(
+ _DEFAULT_TIMEOUT, _DEFAULT_RETRIES)
+def GetAVDs():
+ """ Returns a list of Android Virtual Devices.
+
+ Returns:
+ A list containing the configured AVDs.
+ """
+ return pylib.android_commands.GetAVDs()
+
+
+@decorators.WithExplicitTimeoutAndRetries(
+ _DEFAULT_TIMEOUT, _DEFAULT_RETRIES)
+def RestartServer():
+ """ Restarts the adb server.
+
+ Raises:
+ CommandFailedError if we fail to kill or restart the server.
+ """
+ pylib.android_commands.AndroidCommands().RestartAdbServer()
+
+
class DeviceUtils(object):
def __init__(self, device):
« no previous file with comments | « build/android/pylib/device/device_errors.py ('k') | build/android/pylib/device/device_utils_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698