build/android/pylib/device/OWNERS - Issue 265743002: [Android] Switch to new interfaces of GetAVDs and RestartAdbServer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/pylib/device/OWNERS

Issue 265743002: [Android] Switch to new interfaces of GetAVDs and RestartAdbServer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase + nitfixes Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	1 set noparent
	bulach 2014/05/13 16:57:53 ops, sorry... I wouldn't do setnoparent, in practi ops, sorry... I wouldn't do setnoparent, in practice I've seen it hurting more by blocking people rather than helping in preventing breakages... but again, up to you. :) (btw, I shouldn't be here!) frankf 2014/05/13 18:16:31 Hmm, I've had the opposite experience where people Hmm, I've had the opposite experience where people bypass the owners (mostly accidentally) and check in code that violates the design and/or style guide. Needing owners to sign off is how it's done in other parts of code base (//build being an exception since it's a hodgepodge) and rest of google. It's specially important since we're going through all this trouble to refactor and get rid of code smell. @John, keep in mind that you're the only here who's actually in the team, so responsibility is on you to be responsive (< 24 hours review time preferably).
1 bulach@chromium.org	2 bulach@chromium.org

2 craigdh@chromium.org	3 craigdh@chromium.org

3 frankf@chromium.org	4 jbudorick@chromium.org

4 pliard@chromium.org

OLD	NEW

« no previous file with comments | « build/android/buildbot/bb_device_steps.py ('k') | build/android/pylib/device/adb_wrapper.py » ('j') | build/android/pylib/device/adb_wrapper.py » ('J')