Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: test/cctest/test-parsing.cc

Issue 2657413002: No need to collect literal counts.
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-function.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index 00c91a4987ad36bf53daccd36409e76ae1eb8a94..1e10fadc84ec71c41d4bdfa80c8c289fe0bb9ce4 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -1307,8 +1307,6 @@ void TestParserSyncWithFlags(i::Handle<i::String> source,
i::Factory* factory = isolate->factory();
uintptr_t stack_limit = isolate->stack_guard()->real_climit();
- int preparser_materialized_literals = -1;
- int parser_materialized_literals = -2;
// Preparse the data.
i::PendingCompilationErrorHandler pending_error_handler;
@@ -1325,8 +1323,7 @@ void TestParserSyncWithFlags(i::Handle<i::String> source,
isolate->counters()->runtime_call_stats());
SetParserFlags(&preparser, flags);
scanner.Initialize(stream.get());
- i::PreParser::PreParseResult result =
- preparser.PreParseProgram(&preparser_materialized_literals, is_module);
+ i::PreParser::PreParseResult result = preparser.PreParseProgram(is_module);
CHECK_EQ(i::PreParser::kPreParseSuccess, result);
}
@@ -1340,9 +1337,6 @@ void TestParserSyncWithFlags(i::Handle<i::String> source,
if (is_module) info.set_module();
i::parsing::ParseProgram(&info);
function = info.literal();
- if (function) {
- parser_materialized_literals = function->materialized_literal_count();
- }
}
// Check that preparsing fails iff parsing fails.
@@ -1412,16 +1406,6 @@ void TestParserSyncWithFlags(i::Handle<i::String> source,
"However, parser and preparser succeeded",
source->ToCString().get());
CHECK(false);
- } else if (test_preparser &&
- preparser_materialized_literals != parser_materialized_literals) {
- v8::base::OS::Print(
- "Preparser materialized literals (%d) differ from Parser materialized "
- "literals (%d) on:\n"
- "\t%s\n"
- "However, parser and preparser succeeded",
- preparser_materialized_literals, parser_materialized_literals,
- source->ToCString().get());
- CHECK(false);
}
}
« no previous file with comments | « src/runtime/runtime-function.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698