Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: src/debug/liveedit.cc

Issue 2657413002: No need to collect literal counts.
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/liveedit.h ('k') | src/factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/liveedit.cc
diff --git a/src/debug/liveedit.cc b/src/debug/liveedit.cc
index c91f280ef00a1073d9ff0a6ff8a8120dd00730f2..e070b2cd30b8e504ec8cd3ebcdfa023ea536ad1e 100644
--- a/src/debug/liveedit.cc
+++ b/src/debug/liveedit.cc
@@ -604,15 +604,17 @@ static int GetArrayLength(Handle<JSArray> array) {
return Smi::cast(length)->value();
}
-void FunctionInfoWrapper::SetInitialProperties(
- Handle<String> name, int start_position, int end_position, int param_num,
- int literal_count, int parent_index, int function_literal_id) {
+void FunctionInfoWrapper::SetInitialProperties(Handle<String> name,
+ int start_position,
+ int end_position, int param_num,
+ int parent_index,
+ int function_literal_id) {
HandleScope scope(isolate());
this->SetField(kFunctionNameOffset_, name);
this->SetSmiValueField(kStartPositionOffset_, start_position);
this->SetSmiValueField(kEndPositionOffset_, end_position);
this->SetSmiValueField(kParamNumOffset_, param_num);
- this->SetSmiValueField(kLiteralNumOffset_, literal_count);
+ this->SetSmiValueField(kLiteralNumOffset, 0);
this->SetSmiValueField(kParentIndexOffset_, parent_index);
this->SetSmiValueField(kFunctionLiteralIdOffset_, function_literal_id);
}
@@ -751,8 +753,6 @@ class FeedbackVectorFixer {
static void PatchFeedbackVector(FunctionInfoWrapper* compile_info_wrapper,
Handle<SharedFunctionInfo> shared_info,
Isolate* isolate) {
- int new_literal_count = compile_info_wrapper->GetLiteralCount();
-
// When feedback metadata changes, we have to create new array instances.
// Since we cannot create instances when iterating heap, we should first
// collect all functions and fix their literal arrays.
@@ -767,8 +767,6 @@ class FeedbackVectorFixer {
// Only create feedback vectors if we already have the metadata.
if (shared_info->is_compiled()) JSFunction::EnsureLiterals(fun);
}
-
- shared_info->set_num_literals(new_literal_count);
}
private:
@@ -1601,7 +1599,6 @@ void LiveEditFunctionTracker::FunctionStarted(FunctionLiteral* fun) {
FunctionInfoWrapper info = FunctionInfoWrapper::Create(isolate_);
info.SetInitialProperties(fun->name(), fun->start_position(),
fun->end_position(), fun->parameter_count(),
- fun->materialized_literal_count(),
current_parent_index_, fun->function_literal_id());
current_parent_index_ = len_;
SetElementSloppy(result_, len_, info.GetJSArray());
« no previous file with comments | « src/debug/liveedit.h ('k') | src/factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698