Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2646)

Unified Diff: content/test/test_render_frame_host.cc

Issue 2657323003: Convert HistoryTabHelper to use the new navigation callbacks. (Closed)
Patch Set: nit Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/test_render_frame_host.cc
diff --git a/content/test/test_render_frame_host.cc b/content/test/test_render_frame_host.cc
index c50f745c4b3516c3c49511ec649049180f65c49f..928e237ab677872d00ae180b27354868f1e2cf68 100644
--- a/content/test/test_render_frame_host.cc
+++ b/content/test/test_render_frame_host.cc
@@ -112,7 +112,7 @@ void TestRenderFrameHost::SimulateNavigationStart(const GURL& url) {
}
OnDidStartLoading(true);
- OnDidStartProvisionalLoad(url, base::TimeTicks::Now());
+ OnDidStartProvisionalLoad(url, std::vector<GURL>(), base::TimeTicks::Now());
SimulateWillStartRequest(ui::PAGE_TRANSITION_LINK);
}
@@ -213,7 +213,8 @@ void TestRenderFrameHost::SimulateNavigationError(const GURL& url,
void TestRenderFrameHost::SimulateNavigationErrorPageCommit() {
CHECK(navigation_handle());
GURL error_url = GURL(kUnreachableWebDataURL);
- OnDidStartProvisionalLoad(error_url, base::TimeTicks::Now());
+ OnDidStartProvisionalLoad(error_url, std::vector<GURL>(),
+ base::TimeTicks::Now());
FrameHostMsg_DidCommitProvisionalLoad_Params params;
params.nav_entry_id = 0;
params.did_create_new_entry = true;
@@ -321,7 +322,8 @@ void TestRenderFrameHost::SendNavigateWithParameters(
// DidStartProvisionalLoad may delete the pending entry that holds |url|,
// so we keep a copy of it to use below.
GURL url_copy(url);
- OnDidStartProvisionalLoad(url_copy, base::TimeTicks::Now());
+ OnDidStartProvisionalLoad(url_copy, std::vector<GURL>(),
+ base::TimeTicks::Now());
SimulateWillStartRequest(transition);
FrameHostMsg_DidCommitProvisionalLoad_Params params;
« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698