Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2657323003: Convert HistoryTabHelper to use the new navigation callbacks. (Closed)
Patch Set: better fix to send this data from the renderer initially Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 01653b009ee97e9d6fc9a956e93bd831b6159e00..8fab04336e7f6b9e2a08fd47eac7f5f33eae4c1d 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -1120,14 +1120,15 @@ void RenderFrameHostImpl::OnDocumentOnLoadCompleted(
void RenderFrameHostImpl::OnDidStartProvisionalLoad(
const GURL& url,
+ const std::vector<GURL>& redirect_chain,
const base::TimeTicks& navigation_start) {
// TODO(clamy): Check if other navigation methods (OpenURL,
// DidFailProvisionalLoad, ...) should also be ignored if the RFH is no longer
// active.
if (!is_active())
return;
- frame_tree_node_->navigator()->DidStartProvisionalLoad(this, url,
- navigation_start);
+ frame_tree_node_->navigator()->DidStartProvisionalLoad(
+ this, url, redirect_chain, navigation_start);
}
void RenderFrameHostImpl::OnDidFailProvisionalLoadWithError(
@@ -3355,7 +3356,7 @@ RenderFrameHostImpl::TakeNavigationHandleForCommit(
}
return NavigationHandleImpl::Create(
- params.url, frame_tree_node_, is_renderer_initiated,
+ params.url, params.redirects, frame_tree_node_, is_renderer_initiated,
params.was_within_same_page, base::TimeTicks::Now(),
pending_nav_entry_id, false); // started_from_context_menu
}
@@ -3407,7 +3408,7 @@ RenderFrameHostImpl::TakeNavigationHandleForCommit(
// pending_nav_entry_id. If the previous handle was a prematurely aborted
// navigation loaded via LoadDataWithBaseURL, propagate the entry id.
return NavigationHandleImpl::Create(
- params.url, frame_tree_node_, is_renderer_initiated,
+ params.url, params.redirects, frame_tree_node_, is_renderer_initiated,
params.was_within_same_page, base::TimeTicks::Now(),
entry_id_for_data_nav, false); // started_from_context_menu
}

Powered by Google App Engine
This is Rietveld 408576698