content/browser/frame_host/navigation_handle_impl_unittest.cc - Issue 2657323003: Convert HistoryTabHelper to use the new navigation callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_handle_impl_unittest.cc

Issue 2657323003: Convert HistoryTabHelper to use the new navigation callbacks. (Closed)

Patch Set: better fix to send this data from the renderer initially Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_handle_impl_unittest.cc

diff --git a/content/browser/frame_host/navigation_handle_impl_unittest.cc b/content/browser/frame_host/navigation_handle_impl_unittest.cc

index 8c9ef716c5db1f84bef8179eba326ca23a10b9ad..f9fcacda57b15b9cd6e9a4ecd27970e090a8382a 100644

--- a/content/browser/frame_host/navigation_handle_impl_unittest.cc

+++ b/content/browser/frame_host/navigation_handle_impl_unittest.cc

@@ -68,7 +68,7 @@ class NavigationHandleImplTest : public RenderViewHostImplTestHarness {

void SetUp() override {

RenderViewHostImplTestHarness::SetUp();

test_handle_ = NavigationHandleImpl::Create(

- GURL(), main_test_rfh()->frame_tree_node(),

+ GURL(), std::vector<GURL>(), main_test_rfh()->frame_tree_node(),

true, // is_renderer_initiated

false, // is_same_page

base::TimeTicks::Now(), 0,