Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2657263002: Experiment with blocking script inside fragment-parser-inserted `<iframe srcdoc>`.

Created:
3 years, 10 months ago by Mike West
Modified:
3 years, 10 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Experiment with blocking script inside fragment-parser-inserted `<iframe srcdoc>`. The discussion at https://github.com/whatwg/html/issues/2300 suggests that `el.innerHTML = "<script>yay();</script>";` should be considered equivalent to `el.innerHTML = "<iframe srcdoc='<script>yay();</script>'></iframe>";`. This patch adds a use counter to measure the impact of such a change, and adds an experimental flag to test the new behavior. BUG=684435 R=jochen@chromium.org

Patch Set 1 #

Patch Set 2 : Bitwise logic is hard. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -10 lines) Patch
A third_party/WebKit/LayoutTests/fast/innerHTML/script-execution.html View 1 chunk +60 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_element_factory.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_element_lookup_trie.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_element_type_helpers.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 1 chunk +12 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElement.h View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp View 2 chunks +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElementTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTagNames.in View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Mike West
WDYT, Jochen?
3 years, 10 months ago (2017-01-27 13:26:51 UTC) #3
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-01-27 15:18:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657263002/20001
3 years, 10 months ago (2017-01-27 15:50:09 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 17:48:08 UTC) #11
Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

Powered by Google App Engine
This is Rietveld 408576698