Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: ui/app_list/views/apps_grid_view_unittest.cc

Issue 265723003: Fix app list drag view being hidden on reparent when synchronous drag is setting up. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app_list_win_stuck_icons_real
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/app_list/views/apps_grid_view_folder_delegate.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/app_list/views/apps_grid_view.h" 5 #include "ui/app_list/views/apps_grid_view.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 virtual void DispatchEndDragEventForReparent( 208 virtual void DispatchEndDragEventForReparent(
209 bool events_forwarded_to_drag_drop_host) OVERRIDE {} 209 bool events_forwarded_to_drag_drop_host) OVERRIDE {}
210 210
211 virtual bool IsPointOutsideOfFolderBoundary(const gfx::Point& point) 211 virtual bool IsPointOutsideOfFolderBoundary(const gfx::Point& point)
212 OVERRIDE { 212 OVERRIDE {
213 return false; 213 return false;
214 } 214 }
215 215
216 virtual bool IsOEMFolder() const OVERRIDE { return false; } 216 virtual bool IsOEMFolder() const OVERRIDE { return false; }
217 217
218 virtual void SetRootLevelDragViewVisible(bool visible) OVERRIDE {}
219
218 bool show_bubble() { return show_bubble_; } 220 bool show_bubble() { return show_bubble_; }
219 221
220 private: 222 private:
221 bool show_bubble_; 223 bool show_bubble_;
222 224
223 DISALLOW_COPY_AND_ASSIGN(TestAppsGridViewFolderDelegate); 225 DISALLOW_COPY_AND_ASSIGN(TestAppsGridViewFolderDelegate);
224 }; 226 };
225 227
226 TEST_F(AppsGridViewTest, CreatePage) { 228 TEST_F(AppsGridViewTest, CreatePage) {
227 // Fully populates a page. 229 // Fully populates a page.
(...skipping 480 matching lines...) Expand 10 before | Expand all | Expand 10 after
708 AppListItemView* item_view = GetItemViewAt(0); 710 AppListItemView* item_view = GetItemViewAt(0);
709 ASSERT_TRUE(item_view); 711 ASSERT_TRUE(item_view);
710 const views::Label* title_label = item_view->title(); 712 const views::Label* title_label = item_view->title();
711 EXPECT_FALSE(title_label->GetTooltipText( 713 EXPECT_FALSE(title_label->GetTooltipText(
712 title_label->bounds().CenterPoint(), &actual_tooltip)); 714 title_label->bounds().CenterPoint(), &actual_tooltip));
713 EXPECT_EQ(title, base::UTF16ToUTF8(title_label->text())); 715 EXPECT_EQ(title, base::UTF16ToUTF8(title_label->text()));
714 } 716 }
715 717
716 } // namespace test 718 } // namespace test
717 } // namespace app_list 719 } // namespace app_list
OLDNEW
« no previous file with comments | « ui/app_list/views/apps_grid_view_folder_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698