Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: sdk/lib/_internal/pub/lib/src/command/serve.dart

Issue 26572010: Improve barback/pub logging. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add missing file. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/command/serve.dart
diff --git a/sdk/lib/_internal/pub/lib/src/command/serve.dart b/sdk/lib/_internal/pub/lib/src/command/serve.dart
index fb192cdaf7c1b4b87b8c11273128b9d59493ca49..a8ea7e2ec1e2fbcfee727fe11f30d518b3927ab9 100644
--- a/sdk/lib/_internal/pub/lib/src/command/serve.dart
+++ b/sdk/lib/_internal/pub/lib/src/command/serve.dart
@@ -17,9 +17,6 @@ import '../io.dart';
import '../log.dart' as log;
import '../utils.dart';
-final _green = getSpecial('\u001b[32m');
-final _red = getSpecial('\u001b[31m');
-final _none = getSpecial('\u001b[0m');
final _arrow = getSpecial('\u2192', '=>');
/// Handles the `serve` pub command.
@@ -80,16 +77,16 @@ class ServeCommand extends PubCommand {
var completer = new Completer();
server.barback.errors.listen((error) {
- log.error("${_red}Build error:\n$error$_none");
+ log.error(log.red("Build error:\n$error"));
});
server.barback.results.listen((result) {
if (result.succeeded) {
// TODO(rnystrom): Report using growl/inotify-send where available.
- log.message("Build completed ${_green}successfully$_none");
+ log.message("Build completed ${log.green('successfully')}");
} else {
log.message("Build completed with "
- "${_red}${result.errors.length}$_none errors.");
+ "${log.red(result.numErrors)} errors.");
}
}, onError: (error) {
if (!completer.isCompleted) completer.completeError(error);
@@ -97,12 +94,12 @@ class ServeCommand extends PubCommand {
server.results.listen((result) {
if (result.isSuccess) {
- log.message("${_green}GET$_none ${result.url.path} $_arrow "
+ log.message("${log.green('GET')} ${result.url.path} $_arrow "
"${result.id}");
return;
}
- var msg = "${_red}GET$_none ${result.url.path} $_arrow";
+ var msg = "${log.red('GET')} ${result.url.path} $_arrow";
var error = result.error.toString();
if (error.contains("\n")) {
log.message("$msg\n${prefixLines(error)}");

Powered by Google App Engine
This is Rietveld 408576698