Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2691)

Unified Diff: pkg/barback/lib/src/phase.dart

Issue 26572010: Improve barback/pub logging. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add missing file. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/barback/lib/src/phase.dart
diff --git a/pkg/barback/lib/src/phase.dart b/pkg/barback/lib/src/phase.dart
index af595e742cecf825bb52e83e4be3b447dec08670..0735827b3ebfc92bfde6fe65e091dbda899ce2a8 100644
--- a/pkg/barback/lib/src/phase.dart
+++ b/pkg/barback/lib/src/phase.dart
@@ -11,6 +11,7 @@ import 'asset_cascade.dart';
import 'asset_id.dart';
import 'asset_node.dart';
import 'asset_set.dart';
+import 'barback_logger.dart';
import 'group_runner.dart';
import 'errors.dart';
import 'phase_forwarder.dart';
@@ -92,6 +93,11 @@ class Phase {
bool get isDirty => _inputs.values.any((input) => input.isDirty) ||
_groups.values.any((group) => group.isDirty);
+ /// A stream that emits an event whenever any transforms in this phase log an
nweiz 2013/10/16 19:41:27 "log" -> "logs"
Bob Nystrom 2013/10/28 23:45:56 Done.
+ /// entry.
+ Stream<LogEntry> get onLog => _onLogPool.stream;
+ final _onLogPool = new StreamPool<LogEntry>.broadcast();
+
/// The phase after this one.
///
/// Outputs from this phase will be passed to it.
@@ -151,6 +157,7 @@ class Phase {
});
_onDirtyPool.add(input.onDirty);
_onDirtyController.add(null);
+ _onLogPool.add(input.onLog);
for (var group in _groups.values) {
group.addInput(node);
@@ -238,6 +245,7 @@ class Phase {
group.remove();
}
_onDirtyPool.close();
+ _onLogPool.close();
}
/// Remove all phases after this one.

Powered by Google App Engine
This is Rietveld 408576698