Chromium Code Reviews| Index: pkg/barback/lib/src/barback.dart |
| diff --git a/pkg/barback/lib/src/barback.dart b/pkg/barback/lib/src/barback.dart |
| index 2393f1f004a27be18f096202a0aaa9bf239eb475..affc1b568cac077cb73d0b8ee6e22c85445d25f9 100644 |
| --- a/pkg/barback/lib/src/barback.dart |
| +++ b/pkg/barback/lib/src/barback.dart |
| @@ -64,8 +64,8 @@ class Barback { |
| /// emitted through the [results] stream's error channel. |
| Stream get errors => _graph.errors; |
| - Barback(PackageProvider provider) |
| - : _graph = new PackageGraph(provider); |
| + Barback(PackageProvider provider, {BarbackLogger logger}) |
|
nweiz
2013/10/16 19:41:27
I'm not a big fan of using injection here. What do
Bob Nystrom
2013/10/28 23:45:56
I thought about that (and it is using streams inte
nweiz
2013/10/29 00:40:13
There's some precedent for this in that buffered s
Bob Nystrom
2013/10/29 18:29:45
Done.
|
| + : _graph = new PackageGraph(provider, logger: logger); |
| /// Gets the asset identified by [id]. |
| /// |