Revert "Revert "change SkColorTable to be immutable""

bench/RepeatTileBench.cpp

Index: bench/RepeatTileBench.cpp
diff --git a/bench/RepeatTileBench.cpp b/bench/RepeatTileBench.cpp
index c311c4af6cc4780648214ca17cd2a09143938513..d17d170e1829b29711b5299028785bcf8f988eea 100644
--- a/bench/RepeatTileBench.cpp
+++ b/bench/RepeatTileBench.cpp
@@ -53,8 +53,8 @@ static uint8_t compute_666_index(SkPMColor c) {
 }
 
 static void convert_to_index666(const SkBitmap& src, SkBitmap* dst) {
-    SkColorTable* ctable = new SkColorTable(216);
-    SkPMColor* colors = ctable->lockColors();
+    SkPMColor storage[216];
+    SkPMColor* colors = storage;
     // rrr ggg bbb
     for (int r = 0; r < 6; r++) {
         int rr = conv_6_to_byte(r);
@@ -66,7 +66,7 @@ static void convert_to_index666(const SkBitmap& src, SkBitmap* dst) {
             }
         }
     }
-    ctable->unlockColors(true);
+    SkColorTable* ctable = new SkColorTable(storage, 216, kPremul_SkAlphaType);

[scroggo, 2013/10/09 21:13:55]

As discussed in person, this preserves the old, dumb behavior of the test, but
maybe we should go ahead and fix it?

[reed1, 2013/10/09 21:29:46]

Done.

     dst->setConfig(SkBitmap::kIndex8_Config, src.width(), src.height());
     dst->allocPixels(ctable);
     ctable->unref();