views: Update event-related API to use PointF/RectF instead of Point/Rect.

chrome/browser/ui/views/frame/opaque_browser_frame_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/opaque_browser_frame_view.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/compiler_specific.h"
@@ skipping 272 matching lines @@
 }
 
 void OpaqueBrowserFrameView::UpdateWindowTitle() {
   if (!frame()->IsFullscreen())
     window_title_->SchedulePaint();
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // OpaqueBrowserFrameView, views::View overrides:
 
-bool OpaqueBrowserFrameView::HitTestRect(const gfx::Rect& rect) const {
+bool OpaqueBrowserFrameView::HitTestRect(const gfx::RectF& rect) const {
   if (!views::View::HitTestRect(rect)) {
     // |rect| is outside OpaqueBrowserFrameView's bounds.
     return false;
   }
 
   // If the rect is outside the bounds of the client area, claim it.
   gfx::RectF rect_in_client_view_coords_f(rect);
   View::ConvertRectToTarget(this, frame()->client_view(),
       &rect_in_client_view_coords_f);
   gfx::Rect rect_in_client_view_coords = gfx::ToEnclosingRect(
       rect_in_client_view_coords_f);
   if (!frame()->client_view()->HitTestRect(rect_in_client_view_coords))
     return true;
 
   // Otherwise, claim |rect| only if it is above the bottom of the tabstrip in
   // a non-tab portion.
   TabStrip* tabstrip = browser_view()->tabstrip();
   if (!tabstrip || !browser_view()->IsTabStripVisible())
     return false;
 
-  gfx::RectF rect_in_tabstrip_coords_f(rect);
-  View::ConvertRectToTarget(this, tabstrip, &rect_in_tabstrip_coords_f);
-  gfx::Rect rect_in_tabstrip_coords = gfx::ToEnclosingRect(
-      rect_in_tabstrip_coords_f);
+  gfx::RectF rect_in_tabstrip_coords(rect);
+  View::ConvertRectToTarget(this, tabstrip, &rect_in_tabstrip_coords);
   if (rect_in_tabstrip_coords.bottom() > tabstrip->GetLocalBounds().bottom()) {
     // |rect| is below the tabstrip.
     return false;
   }
 
   if (tabstrip->HitTestRect(rect_in_tabstrip_coords)) {
     // Claim |rect| if it is in a non-tab portion of the tabstrip.
     return tabstrip->IsRectInWindowCaption(rect_in_tabstrip_coords);
   }
 
   // The window switcher button is to the right of the tabstrip but is
   // part of the client view.
   views::View* window_switcher_button =
       browser_view()->window_switcher_button();
   if (window_switcher_button && window_switcher_button->visible()) {
     gfx::RectF rect_in_window_switcher_coords_f(rect);

[tdresser, 2014/05/02 13:19:06]

|rect_in_window_switcher_coords_f| should probably be renamed
|rect_in_window_switcher_coords|, as we're moving away from using the "_f"
suffix.

     View::ConvertRectToTarget(this, window_switcher_button,
         &rect_in_window_switcher_coords_f);
-    gfx::Rect rect_in_window_switcher_coords = gfx::ToEnclosingRect(
-        rect_in_window_switcher_coords_f);
-
-    if (window_switcher_button->HitTestRect(rect_in_window_switcher_coords))
+    if (window_switcher_button->HitTestRect(rect_in_window_switcher_coords_f))
       return false;
   }
 
   // We claim |rect| because it is above the bottom of the tabstrip, but
   // neither in the tabstrip nor in the window switcher button. In particular,
   // the avatar label/button is left of the tabstrip and the window controls
   // are right of the tabstrip.
   return true;
 }
 
@@ skipping 571 matching lines @@
 
 int OpaqueBrowserFrameView::GetTopAreaHeight() const {
   gfx::ImageSkia* frame_image = GetFrameImage();
   int top_area_height = frame_image->height();
   if (browser_view()->IsTabStripVisible()) {
     top_area_height = std::max(top_area_height,
       GetBoundsForTabStrip(browser_view()->tabstrip()).bottom());
   }
   return top_area_height;
 }